Fix scoping bug for errors on collector service Run #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
phenixrizen
force-pushed
the
fix-collector-error
branch
from
83eabc0
to
b6fa94f
Compare
NathanielRN
reviewed
Dec 2, 2021
collector/collector.go
Outdated
| err = appErr | ||
| } | ||
| }() | ||
| err := c.svc.Run(context.Background()) |
There was a problem hiding this comment.
Just curious, why is context.Background() better than ctx here?
There was a problem hiding this comment.
Good catch that should be the passed context. I was working off a older version that had no context passed to Run.
NathanielRN
approved these changes
Dec 2, 2021
simplify code
phenixrizen
force-pushed
the
fix-collector-error
branch
from
e6b1dfb
to
5518a90
Compare
|
Any update on getting this merged would like to use this instead of a fork. |
|
It's hard with people on holidays I guess, but I also would like to see this merged because I have ran into it too 😞 @codeboten think you could merge this when you have a chance? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a tab error in my config yaml and the extension layer collector was hanging with no error output which led me to this bug.
The current logic will never receive the error returned from
appErr := c.svc.Run(ctx)because error will be out of scope and the collector will hang. This creates a channel and assures we check the error. This allows us to get the config error.